New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(managers): yaml schema checks #26811
refactor(managers): yaml schema checks #26811
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
🎉 This PR is included in version 37.213.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
||
const DockerComposeService = z.object({ | ||
image: z.string().optional(), | ||
build: z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@secustor build
does not need to be an object in the compose spec, it may be, and often is, a string.
https://docs.docker.com/compose/compose-file/compose-file-v2/#build
This has broken a bunch of our compose files that use the shorthand build: ./path
and compose files can no longer be parsed.
Resolves issue introduced by renovatebot#26811 See: https://docs.docker.com/compose/compose-file/compose-file-v2/#build Signed-off-by: Kyle Harding <kyle@balena.io>
Resolves issue introduced by renovatebot#26811 See: https://docs.docker.com/compose/compose-file/compose-file-v2/#build Signed-off-by: Kyle Harding <kyle@balena.io>
Resolves issue introduced by renovatebot#26811 See: https://docs.docker.com/compose/compose-file/compose-file-v2/#build Signed-off-by: Kyle Harding <kyle@balena.io>
@secustor This PR has broken Argo-CD for me. I keep getting these errors now "error": {
"message": "Schema error",
"stack": "ZodError: Schema error\n at Object.get error [as error] (/opt/homebrew/Cellar/renovate/37.218.0/libexec/lib/node_modules/renovate/node_modules/zod/lib/types.js:43:31)\n at parseYaml (/opt/homebrew/Cellar/renovate/37.218.0/libexec/lib/node_modules/renovate/lib/util/yaml.ts:53:23)\n at Object.extractPackageFile (/opt/homebrew/Cellar/renovate/37.218.0/libexec/lib/node_modules/renovate/lib/modules/manager/argocd/extract.ts:36:28)\n at extractPackageFile (/opt/homebrew/Cellar/renovate/37.218.0/libexec/lib/node_modules/renovate/lib/modules/manager/index.ts:75:9)\n at getManagerPackageFiles (/opt/homebrew/Cellar/renovate/37.218.0/libexec/lib/node_modules/renovate/lib/workers/repository/extract/manager-files.ts:45:43)\n at /opt/homebrew/Cellar/renovate/37.218.0/libexec/lib/node_modules/renovate/lib/workers/repository/extract/index.ts:57:28\n at async Promise.all (index 0)\n at extractAllDependencies (/opt/homebrew/Cellar/renovate/37.218.0/libexec/lib/node_modules/renovate/lib/workers/repository/extract/index.ts:54:26)\n at extract (/opt/homebrew/Cellar/renovate/37.218.0/libexec/lib/node_modules/renovate/lib/workers/repository/process/extract-update.ts:140:28)\n at extractDependencies (/opt/homebrew/Cellar/renovate/37.218.0/libexec/lib/node_modules/renovate/lib/workers/repository/process/index.ts:154:26)\n at Object.renovateRepository (/opt/homebrew/Cellar/renovate/37.218.0/libexec/lib/node_modules/renovate/lib/workers/repository/index.ts:63:9)\n at attributes.repository (/opt/homebrew/Cellar/renovate/37.218.0/libexec/lib/node_modules/renovate/lib/workers/global/index.ts:200:11)\n at start (/opt/homebrew/Cellar/renovate/37.218.0/libexec/lib/node_modules/renovate/lib/workers/global/index.ts:185:7)\n at /opt/homebrew/Cellar/renovate/37.218.0/libexec/lib/node_modules/renovate/lib/renovate.ts:18:22",
"issues": {
"kind": "Invalid literal value, expected \"ApplicationSet\"",
"spec": {
"sources": {"1": {"targetRevision": "Required"}},
"template": "Required"
}
}
}, All my Argo CD manifest are Have currently reverted back to 37.212.0 and everything is working I don't seem to be able to open an issue in this repo so am just posting in the PR hoping this will be seen. Thanks |
@sherif-fanous please create a discussion under category "Report a problem" and include either a reproduction or sufficient logs/description |
Changes
add yaml schema checks for some managers. This can be considered batch 1
Context
I have tried to keep changes to a minimum and have only removed/reworked logic where it has been obvious that it can not be reached anymore.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: