Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fetch raw config from within config migration #26891

Merged
merged 1 commit into from Jan 28, 2024

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Jan 28, 2024

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@RahulGautamSingh
Copy link
Collaborator

If we already look for raw content inside detectRepoConfig won't this be redundant?

@rarkins
Copy link
Collaborator Author

rarkins commented Jan 28, 2024

I want to simplify that function. The only reason why raw is used is in one place, and to detect indents

@rarkins
Copy link
Collaborator Author

rarkins commented Jan 28, 2024

Related: #26892

@rarkins rarkins added this pull request to the merge queue Jan 28, 2024
Merged via the queue into main with commit 535c7ae Jan 28, 2024
36 checks passed
@rarkins rarkins deleted the refactor/config-migrate-raw branch January 28, 2024 13:45
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.154.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

rvanbutselaar pushed a commit to rvanbutselaar/renovate that referenced this pull request Feb 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants