Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(npm): don't set default versioning #26927

Merged
merged 1 commit into from Jan 29, 2024
Merged

Conversation

viceice
Copy link
Member

@viceice viceice commented Jan 29, 2024

Changes

The npm manager shouldn't set a default versioniong, it should be the datasource which decides the versioning.
I've added explicit npm versioning to git sources to not cause a behavior change there.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice added this pull request to the merge queue Jan 29, 2024
Merged via the queue into main with commit eb782cc Jan 29, 2024
36 checks passed
@viceice viceice deleted the fix/npm-default-versioning branch January 29, 2024 21:29
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.158.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

rvanbutselaar pushed a commit to rvanbutselaar/renovate that referenced this pull request Feb 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants