Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(github): use repoCache even if not initial #27039

Merged
merged 1 commit into from Feb 3, 2024
Merged

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Feb 3, 2024

Changes

Context

Cache of first page of pulls wasn't working because repoCache=true was only set if it was the initial (cold cache) fetch.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins added this pull request to the merge queue Feb 3, 2024
@viceice
Copy link
Member

viceice commented Feb 3, 2024

can we add tests?

Merged via the queue into main with commit 413084b Feb 3, 2024
36 checks passed
@rarkins rarkins deleted the fix/github-pulls-cache branch February 3, 2024 15:54
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.168.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants