New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(github): Add 30 minutes debounce between cache syncs #27058
feat(github): Add 30 minutes debounce between cache syncs #27058
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blank review to ensure I test it thoroughly!
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
When running against
I don't get that on main branch |
On main branch, dependency.releases.length is 55, on this PR it's 50 and missing v4.0.0. When I reset my /tmp/renovate to clear cache, it worked (both cold and hot cache). I attempted to reproduce the problem by first running on main and then switching to the PR branch, but the lookup warnings aren't showing anymore. However I did see an autoclosing of this PR which I bet is the same root cause: renovate-reproductions/t2#4 And this PR gets edited to have a lower version: |
I've managed to reproduce it, looking for a cause |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷♂️
🎉 This PR is included in version 37.197.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes
This PR prevents any sync for 30 minutes time period, if the package is public, by caching additional flag related to package ability to be persistent (i.e. when it's public).
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: