New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(maven): bumpVersion update SNAPSHOT versions #27274
fix(maven): bumpVersion update SNAPSHOT versions #27274
Conversation
in current state this PR has (probably unexpected) breaking changes |
Here is a table with the old (useless) behaviour and the new:
We can see that the old behaviour was only useful in the case of a release version (as long as the bump was not For the case of a release number having an additional qualifier, I'm not sure what the expected behaviour should be.
|
@jonasrutishauser FYI we are planning to release v38 this week, so if you're interested in having these changes as part of it then please get back to us soon. Otherwise, it can be merged later in v38 if you remove the breaking changes, or in v39 sometime in future if you're certain that the changes need to be breaking/backwards-incompatible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this being non-breaking
please avoid mentioning in commits |
🎉 This PR is included in version 37.328.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes
allow to bump maven SNAPSHOT-Versions (since this is the usual maven way)
Context
#14762 & #14763
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: