feat(manager/gomod): Added support for the gomod toolchain directive

[kvanzuijlen]

Changes

Added support for the go.mod toolchain directive to the gomod manager.

Context

Go 1.21 introduced the toolchain directive. This directive, contrary to the go directive, should be updated by Renovate, see #24427 and #16715. Closes #24427

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository: closed kvanzuijlen/renovate-reproduction-gomod-toolchain#2

[kvanzuijlen]

I'll rerun against the repository to be 100% sure.

[kvanzuijlen]

I'll rerun against the repository to be 100% sure.

Ran and verified! Updated the PR description to link to the new PR.

[rarkins]

Related to this PR, does this mean that Renovate should use the tool chain directive as the source of truth for which version of go to install/run ?

[kvanzuijlen]

Related to this PR, does this mean that Renovate should use the tool chain directive as the source of truth for which version of go to install/run ?

@rarkins As far as I understand, the go-binary itself will take care of that, see https://go.dev/doc/toolchain#select

[rarkins]

Related to this PR, does this mean that Renovate should use the tool chain directive as the source of truth for which version of go to install/run ?

@rarkins As far as I understand, the go-binary itself will take care of that

So we'll continue installing the latest go, as we do today? Technically we install the latest matching "^[go mod directive value]" but that's the same thing as latest.

[kvanzuijlen]

Related to this PR, does this mean that Renovate should use the tool chain directive as the source of truth for which version of go to install/run ?

@rarkins As far as I understand, the go-binary itself will take care of that

So we'll continue installing the latest go, as we do today? Technically we install the latest matching "^[go mod directive value]" but that's the same thing as latest.

As long as that is go 1.21+ that should be fine yes

[rarkins]

@kvanzuijlen do you have time to continue this?

[viceice]

please add the depType as suggested

[kvanzuijlen]

@kvanzuijlen do you have time to continue this?

Yes, I will continue with it early next week!

[viceice]

otherwise LGTM

[kramvan1]

@kvanzuijlen Not sure I follow the code, but need to only update the toolchain if it already exists in the go.mod, I don't think renovate should ever add it directly.

[kvanzuijlen]

@kvanzuijlen Not sure I follow the code, but need to only update the toolchain if it already exists in the go.mod, I don't think renovate should ever add it directly.

It doesn't, it checks for a line starting with toolchain go and if it exists it extracts the version if it exists unless I'm misremembering (i'm on my phone now)

[renovate-release]

🎉 This PR is included in version 37.283.0 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)
• 37.283.0

Your semantic-release bot 📦🚀