Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datasource/go): don't strip api/ from packageName on gitlab #27635

Merged
merged 3 commits into from Feb 29, 2024

Conversation

ManuelB
Copy link
Contributor

@ManuelB ManuelB commented Feb 29, 2024

Changes

Added 'api/' to condition

Discussion is here: #27595 (reply in thread)

Context

A bug was introduced by an earlier pull requests

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@ManuelB ManuelB changed the title Fixed discussion 27595 by checking that prefix is not api/ fix(go) Fixed discussion 27595 by checking that prefix is not api/ Feb 29, 2024
@ManuelB ManuelB changed the title fix(go) Fixed discussion 27595 by checking that prefix is not api/ fix(go): Fixed discussion 27595 by checking that prefix is not api/ Feb 29, 2024
@rarkins rarkins requested a review from viceice February 29, 2024 09:30
@viceice viceice changed the title fix(go): Fixed discussion 27595 by checking that prefix is not api/ fix(datasource/go): don't strip api/ from packageName on gitlab Feb 29, 2024
viceice
viceice previously approved these changes Feb 29, 2024
@ManuelB
Copy link
Contributor Author

ManuelB commented Feb 29, 2024

@viceice I forgot to add the fixture. Did this now.

@viceice
Copy link
Member

viceice commented Feb 29, 2024

let's wait for this to be merged to main:

@viceice viceice added this pull request to the merge queue Feb 29, 2024
Merged via the queue into renovatebot:main with commit 158fa38 Feb 29, 2024
35 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.220.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants