Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix jest wrapper #27636

Merged
merged 6 commits into from Feb 29, 2024
Merged

test: fix jest wrapper #27636

merged 6 commits into from Feb 29, 2024

Conversation

viceice
Copy link
Member

@viceice viceice commented Feb 29, 2024

Changes

set proper exitcode from jest wrapper

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

rarkins
rarkins previously approved these changes Feb 29, 2024
@viceice viceice added this pull request to the merge queue Feb 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 29, 2024
@rarkins
Copy link
Collaborator

rarkins commented Feb 29, 2024

@viceice merge queue failure
image

@viceice viceice added the ci:fulltest Run full test suite on all platforms label Feb 29, 2024
@viceice
Copy link
Member Author

viceice commented Feb 29, 2024

@viceice merge queue failure
image

do you know the test?

rarkins
rarkins previously approved these changes Feb 29, 2024
@viceice viceice added this pull request to the merge queue Feb 29, 2024
Merged via the queue into main with commit 3d2cabb Feb 29, 2024
48 checks passed
@viceice viceice deleted the test/fix-jest-wrapper branch February 29, 2024 15:10
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.220.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@HenrikPoulsen
Copy link
Contributor

I imagine that this PR is why I see the following test failures in my custom tests in my fork:

-         "ProgramW6432": "C:/Program Files",
+         "ProgramW6432": "/Program Files",

I guess it's not a big issue since it's just for the snapshots. But it is definitely weird and unexpected. Anyone seeing those snapshots later will go "Well that's an invalid windows path"

@viceice
Copy link
Member Author

viceice commented Mar 1, 2024

yes. feel free to open a PR with a better fix which works cross platform.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci:fulltest Run full test suite on all platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants