Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rebase checkbox directly to PR bodies (GitHub, GitLab) #2766

Closed
rarkins opened this issue Nov 8, 2018 · 6 comments
Closed

Add rebase checkbox directly to PR bodies (GitHub, GitLab) #2766

rarkins opened this issue Nov 8, 2018 · 6 comments
Assignees
@rarkins
Labels
platform:github GitHub Platform platform:gitlab GitLab Platform priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Nov 8, 2018

Same functionality as with Master Issue checkboxes

Need to add webhook too.
@kayoub5
Copy link
Contributor

kayoub5 commented Nov 8, 2018

@rarkins the checkbox thing, only works for github

@rarkins
Copy link
Collaborator Author

rarkins commented Nov 8, 2018

GitLab now seems to support it too.

@kayoub5
Copy link
Contributor

kayoub5 commented Nov 8, 2018

BitBucket does not https://bitbucket.org/site/master/issues/8586/support-task-lists-in-markdown-bb-9699

@rarkins rarkins added platform:github GitHub Platform platform:gitlab GitLab Platform type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others ready labels Nov 11, 2018
@rarkins rarkins changed the title PRs include rebase checkbox Add rebase checkbox directly to PR bodies (GitHub, GitLab) Nov 16, 2018
@adam-moss
Copy link
Contributor

@rarkins just an FYI - GitLab have merged in a rebase api method for merge requests - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/23296

@rarkins
Copy link
Collaborator Author

rarkins commented Nov 29, 2018

@adam-moss thanks for the link. I’m not sure we can use it though:

  • if we are rebasing because of conflict, GitLab can’t do it
  • even in other cases it’s still best to regenerate the lock file if other versions have been updated

But if there are no conflicts and the user wants to do it then it should be fine. I assume they do it in a way that won’t look like an “edit” to Renovate and it can keep updating it itself if necessary

@rarkins rarkins self-assigned this Dec 5, 2018
@rarkins rarkins closed this as completed in 6ba13f9 Dec 5, 2018
@rarkins rarkins removed the ready label Dec 5, 2018
@renovate-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 13.137.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rarkins rarkins

Labels
platform:github GitHub Platform platform:gitlab GitLab Platform priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kayoub5 @adam-moss @rarkins @renovate-bot