Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datasource/npm): mark all releases deprecated if latest deprecated #27875

Merged
merged 3 commits into from Mar 15, 2024
Merged

fix(datasource/npm): mark all releases deprecated if latest deprecated #27875

merged 3 commits into from Mar 15, 2024

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Mar 12, 2024

Changes

  • Removes legacy cache fallback
  • Adds npm cache revision
  • Fixes logic so that all npm versions are deprecated if latest is deprecated

Context

#27847 (comment)

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice March 12, 2024 11:05
@rarkins rarkins mentioned this pull request Mar 12, 2024
Merged
6 tasks
@rarkins rarkins enabled auto-merge March 12, 2024 12:04
viceice
viceice reviewed Mar 14, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/modules/datasource/npm/get.ts Outdated Show resolved Hide resolved
rarkins and others added 2 commits March 14, 2024 11:37
@rarkins @viceice
Update get.ts
efba6ab 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@rarkins
Merge branch 'main' into fix/npm-latest-deprecated
4a11c29
@rarkins rarkins added this pull request to the merge queue Mar 15, 2024
Merged via the queue into main with commit c1517aa Mar 15, 2024
35 checks passed
@rarkins rarkins deleted the fix/npm-latest-deprecated branch March 15, 2024 07:52
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.246.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rarkins @renovate-release @viceice