fix(versioning/poetry): version strings that include a leading zero in their pre, post, or dev fields #28158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henry-fn
changed the title
rarkins
changed the title
auto-merge was automatically disabled
March 27, 2024 21:07
Head branch was pushed to by a user without write access
|
sorry 🤦 I clearly can't read instructions and didn't realize this had already been looked at before I pushed a small change to the tests |
|
@rarkins sorry I pushed I hadn't realized you had already taken a look. It was a tiny change to the tests to make them look more similar in style. |
viceice
reviewed
Apr 5, 2024
viceice
requested changes
Apr 8, 2024
viceice
approved these changes
Apr 9, 2024
|
🎉 This PR is included in version 37.280.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Allows parsing of python version strings that include a leading zero in their pre, post, or dev fields (allowed by Python but not by Semver). An example would be 0.3.0b01 which is valid but would fail to parse under the old code.
Context
Our self hosted renovate was failing to update one package that uses this versioning scheme
Documentation (please check one with an [x])
[ ] I have updated the documentation, or
[x] No documentation update is required
How I've tested my work (please select one)
I have verified these changes via:
[] Code inspection only, or
[x] Newly added/modified unit tests, or
[ ] No unit tests but ran on a real repository, or
[ ] Both unit tests + ran on a real repository