Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(manager/terraform): fix hash generation with directory #28326

Merged
merged 6 commits into from Apr 13, 2024
Merged

fix(manager/terraform): fix hash generation with directory #28326

merged 6 commits into from Apr 13, 2024

Conversation

secustor
Copy link
Collaborator

Changes

Add supports for directories in our implementation of the Go hashing algorithm... with some caveats

Context

Closes #27433

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@secustor secustor requested a review from viceice April 10, 2024 21:25
viceice
viceice reviewed Apr 11, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/modules/manager/terraform/lockfile/hash.ts Outdated Show resolved Hide resolved
lib/modules/manager/terraform/lockfile/hash.ts Outdated Show resolved Hide resolved
lib/modules/manager/terraform/lockfile/hash.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/terraform/lockfile/hash.ts Outdated Show resolved Hide resolved
lib/util/fs/index.ts Outdated Show resolved Hide resolved
lib/modules/manager/terraform/lockfile/hash.ts Outdated Show resolved Hide resolved
@secustor secustor requested a review from viceice April 11, 2024 20:44
@secustor secustor requested a review from viceice April 13, 2024 10:48
viceice
viceice previously approved these changes Apr 13, 2024
View reviewed changes
@viceice viceice added this pull request to the merge queue Apr 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 13, 2024
@secustor secustor added this pull request to the merge queue Apr 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 13, 2024
@secustor secustor added this pull request to the merge queue Apr 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 13, 2024
@secustor secustor added the ci:fulltest Run full test suite on all platforms label Apr 13, 2024
@secustor secustor enabled auto-merge April 13, 2024 12:17
@secustor secustor added this pull request to the merge queue Apr 13, 2024
Merged via the queue into renovatebot:main with commit a1cad20 Apr 13, 2024
50 checks passed
@secustor secustor deleted the feat/fix-hash-generation-with-directory branch April 13, 2024 15:59
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.291.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viceice viceice viceice approved these changes

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
ci:fulltest Run full test suite on all platforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating lock file files if Terraform build artifact contains folder
4 participants
@secustor @renovate-release @viceice @rarkins