Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fleet): extract dependencies from helm blocks with OCI-based helm charts #28352

Merged
merged 4 commits into from Apr 13, 2024

Conversation

webD97
Copy link
Contributor

@webD97 webD97 commented Apr 11, 2024

Changes

This PR updates the fleet manager to handle helm charts with OCI-based registries.

Context

Previously, the fleet manager ignored OCI-based helm blocks because they do not set a .repo field. Instead, the .chart field is set to an oci:// URL (see (https://fleet.rancher.io/ref-fleet-yaml)[fleet.yaml docs]. Valid example:

helm:
  chart: oci://registry-1.docker.io/bitnamicharts/external-dns
  version: 7.0.2
  releaseName: external-dns

targetCustomizations:
  - name: target-1
    helm:
      chart: oci://registry-1.docker.io/bitnamicharts/external-dns
      version: 7.0.2

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

lib/modules/manager/fleet/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/fleet/extract.ts Outdated Show resolved Hide resolved
@webD97 webD97 requested a review from viceice April 12, 2024 15:14
lib/modules/manager/fleet/extract.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/fleet/extract.ts Show resolved Hide resolved
lib/modules/manager/fleet/extract.ts Outdated Show resolved Hide resolved
@webD97 webD97 requested review from secustor and viceice April 13, 2024 16:18
@secustor secustor added this pull request to the merge queue Apr 13, 2024
Merged via the queue into renovatebot:main with commit cd02e93 Apr 13, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.292.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants