Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong warning for customizeDashboard.repoProblemsHeader validation #28436

Closed
viceice opened this issue Apr 16, 2024 · 4 comments · Fixed by #28438
Closed

Wrong warning for customizeDashboard.repoProblemsHeader validation #28436

viceice opened this issue Apr 16, 2024 · 4 comments · Fixed by #28438
Assignees
Labels
core:config Related to config capabilities and presets priority-2-high Bugs impacting wide number of users or very important features type:bug Bug fix of existing functionality

Comments

@viceice
Copy link
Member

viceice commented Apr 16, 2024

Describe the proposed change(s).

DEBUG: Using RE2 regex engine
DEBUG: Parsing configs
DEBUG: Checking for config file in /runner/renovate/job_config.json
DEBUG: Detected config in env RENOVATE_CONFIG
{
  "config": {
    "extends": [
      "mergeConfidence:all-badges"
    ],
    "prFooter": "This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here]([https://developer.mend.io/{{platform}}/{{repository}}](https://developer.mend.io/%7B%7Bplatform%7D%7D/%7B%7Brepository%7D%7D)).",
    "prHeader": "[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)",
    "redisUrl": "redis://xxxx:6379",
    "binarySource": "install",
    "platformCommit": true,
    "repositoryCache": "enabled",
    "cacheTtlOverride": {
      "datasource-docker-hub-tags": 90
    },
    "onboardingConfig": {
      "$schema": "https://docs.renovatebot.com/renovate-schema.json",
      "extends": [
        "config:recommended"
      ]
    },
    "gitIgnoredAuthors": [
      "29139614+renovate[bot]@users.noreply.github.com"
    ],
    "customizeDashboard": {
      "repoProblemsHeader": "These problems occurred while renovating this repository. [View logs]([https://developer.mend.io//{{platform}}/{{repository}}](https://developer.mend.io//%7B%7Bplatform%7D%7D/%7B%7Brepository%7D%7D))."
    },
    "repositoryCacheType": "s3://xxxx/renovate/",
    "dependencyDashboardFooter": "\n- [ ] <!-- manual job -->Check this box to trigger a request for Renovate to run again on this repository\n",
    "allowedPostUpgradeCommands": [
      "^git add --all$",
      "^git reset$",
      "^npx beachball change( --no-fetch)? --no-commit --type (patch|none) --message '{{{commitMessage}}}'$",
      "^pwd$"
    ],
    "allowPostUpgradeCommandTemplating": true
  }
}

WARN: Config validation errors found in RENOVATE_CONFIG
{
  "errors": [
    {
      "topic": "Configuration Error",
      "message": "Invalid configuration option: customizeDashboard.repoProblemsHeader"
    }
  ]
}

it seems our validation logic is wrong.

@viceice viceice added type:bug Bug fix of existing functionality priority-2-high Bugs impacting wide number of users or very important features core:config Related to config capabilities and presets labels Apr 16, 2024
@nabeelsaabna
Copy link
Contributor

In the APP these warnings started after upgrading from 37.269.2 to 37.293.0

@nabeelsaabna
Copy link
Contributor

@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 37.301.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core:config Related to config capabilities and presets priority-2-high Bugs impacting wide number of users or very important features type:bug Bug fix of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants