Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gomod): go.mod directive should not bump by default #28475

Merged
merged 3 commits into from Apr 17, 2024

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Apr 17, 2024

Changes

Avoids bumping go.mod directive if new version is compatible

Context

Fixes #28474

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins enabled auto-merge April 17, 2024 10:06
@rarkins rarkins marked this pull request as draft April 17, 2024 10:10
auto-merge was automatically disabled April 17, 2024 10:10

Pull request was converted to draft

@rarkins rarkins marked this pull request as ready for review April 17, 2024 10:20
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So replace should only replace if new value is not matching current range?

@rarkins rarkins added this pull request to the merge queue Apr 17, 2024
Merged via the queue into main with commit 2902d17 Apr 17, 2024
39 of 53 checks passed
@rarkins rarkins deleted the fix/28474-go-mod-directive-bump branch April 17, 2024 11:07
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.303.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

database64128 added a commit to database64128/renovate-config that referenced this pull request Apr 21, 2024
renovatebot/renovate#28475 fixed the issue, so the rule is no longer needed.

This reverts commit c20440b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go.mod directive incorrectly bumped
4 participants