Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terragrunt): remove .git from package name #28726

Merged

Conversation

lstoeferle
Copy link
Contributor

Changes

Unfortunately the .git part in the terragrunt source URL is not cleaned up when setting the packageName (typically set if a ssh URL is specified). This leads to failing API calls (e.g. GitLab API).

This PR changes the terragrunt manager to ignore the .git part while setting the packageName value.

Context

Forward fix #28075

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

lib/modules/manager/terragrunt/modules.ts Outdated Show resolved Hide resolved
lib/modules/manager/terragrunt/modules.ts Outdated Show resolved Hide resolved
@lstoeferle lstoeferle requested a review from viceice April 29, 2024 11:03
@viceice viceice changed the title fix(terragrunt): .git in the source URL leading to failed API calls fix(terragrunt): remove .git from package name Apr 29, 2024
@viceice viceice added this pull request to the merge queue Apr 29, 2024
Merged via the queue into renovatebot:main with commit e185788 Apr 29, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.328.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants