Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/maven): support .mvn/extensions.xml #28893

Merged

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented May 7, 2024

Changes

  • Add new function which parses & validates the .mvn/extensions.xml (extractExtensions)
  • Add another function which extract all extensions from it using the existing deepExtract function (parseExtensions)
  • Add test

Context

Closes: #28843

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing coverage

lib/modules/manager/maven/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/maven/index.ts Outdated Show resolved Hide resolved
lib/modules/manager/maven/extract.ts Outdated Show resolved Hide resolved
@rarkins rarkins requested a review from Churro May 7, 2024 09:48
lib/modules/manager/maven/index.ts Outdated Show resolved Hide resolved
lib/modules/manager/maven/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/maven/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/maven/extract.spec.ts Outdated Show resolved Hide resolved
@viceice viceice added this pull request to the merge queue May 8, 2024
Merged via the queue into renovatebot:main with commit 468b0d1 May 8, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.350.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maven: support extensions.xml
5 participants