Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datasource(dotnet-version): use the release_date as releaseTimestamp #28968

Closed
RahulGautamSingh opened this issue May 10, 2024 · 1 comment
Closed
Labels
datasource:dotnet-version priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@RahulGautamSingh
Copy link
Collaborator

RahulGautamSingh commented May 10, 2024

Describe the proposed change(s).

The dotnet-version first fetches all the available channels (major version) from the https://dotnetcli.blob.core.windows.net/dotnet/release-metadata/releases-index.json url.
Example
This reponse returns a json object, which contains the list of all channels, and links which can be used to fetch the versions available for each.

We then fetch the releases for each channel using that link. In this response along with other information there is the release_date field, which can be used as the releaseTimestamp.
Example

@RahulGautamSingh RahulGautamSingh added priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others needs-discussion Issue requires a GitHub Discussion first labels May 10, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 10, 2024
@RahulGautamSingh RahulGautamSingh added datasource:dotnet-version and removed needs-discussion Issue requires a GitHub Discussion first labels May 10, 2024
@renovatebot renovatebot deleted a comment from github-actions bot May 10, 2024
@rarkins rarkins added the type:feature Feature (new functionality) label May 10, 2024
@RahulGautamSingh
Copy link
Collaborator Author

False flag!

This datasource returns releaseTimestamp field. I missed it because I only checked the tests and they didn't include them. But when I checked the schema, it was clear that they were being returned, just not tested.

I will modify the tests instead to include the releaseTimestamp field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasource:dotnet-version priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

2 participants