Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datasource/docker): use digest from header if available #29065

Merged
merged 2 commits into from
May 14, 2024

Conversation

viceice
Copy link
Member

@viceice viceice commented May 14, 2024

Changes

Use digest from response header if it's a valid manifest, so we don't fallback to body computation.
Added todo's for another issue, whiuch needs more refactoring.
Added headers and body when manifest parsing fails.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested review from rarkins and secustor May 14, 2024 11:36
@viceice
Copy link
Member Author

viceice commented May 14, 2024

compare without whitespace for less changes

@viceice viceice added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit 3bcafbb May 14, 2024
37 checks passed
@viceice viceice deleted the fix/docker/use-digest-from-header branch May 14, 2024 13:16
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.363.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

zharinov pushed a commit to zharinov/renovate that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants