Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor raiseDeprecationWarnings into suppressNotifications #2909

Closed
rarkins opened this issue Dec 8, 2018 · 4 comments · Fixed by #2921
Closed

refactor raiseDeprecationWarnings into suppressNotifications #2909

rarkins opened this issue Dec 8, 2018 · 4 comments · Fixed by #2921
Labels
priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:refactor Refactoring or improving of existing code

Comments

@rarkins
Copy link
Collaborator

rarkins commented Dec 8, 2018

Remove this option:

{
name: 'raiseDeprecationWarnings',
description: 'Raise deprecation warnings in issues whenever found',
type: 'boolean',
default: true,
},
{

Instead, replace it with a new value "deprecationWarningIssues" inside "suppressNotifications".

There will also need to be a rule added to https://github.com/renovatebot/renovate/blob/master/lib/config/migration.js that:

  • deletes raiseDeprecationWarnings if found
  • adds "deprecationWarningIssues" to the suppressNotifications array if the user set raiseDeprecationWarnings=false
@rarkins rarkins added in progress priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:refactor Refactoring or improving of existing code labels Dec 8, 2018
@renovate-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 13.142.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tuckbick
Copy link

tuckbick commented Jan 2, 2020

How does one remove deprecationWarningIssues from suppressNotifications[] if it's always being set?

@rarkins
Copy link
Collaborator Author

rarkins commented Jan 3, 2020

It's maybe not possible right now - I need to check. Can you create a new issue like "re-enable deprecated dependency warnings" so that I can track it? The problem was our ensureIssueOnce function misfired in some circumstances (GitHub's API behaved differently if there's a personal access token in use vs an app token) so it was disabled out of caution.

@tuckbick
Copy link

tuckbick commented Jan 3, 2020

Thanks for your feedback. Here is the issue I've filed: #5098

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:refactor Refactoring or improving of existing code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants