Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dashboard): show deprecated dependency warnings #29694

Merged
merged 11 commits into from
Jun 17, 2024
Merged

feat(dashboard): show deprecated dependency warnings #29694

merged 11 commits into from
Jun 17, 2024

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Jun 16, 2024 •
edited

Changes

Adds a new warning to the Dependency Dashboard if deprecated dependencies and/or dependencies with replacements are found.

Example screenshot:

image

Context

Closes #5098

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins mentioned this pull request Jun 16, 2024
Closed
HonkingGoose
HonkingGoose suggested changes Jun 16, 2024
View reviewed changes
docs/usage/key-concepts/dashboard.md Outdated Show resolved Hide resolved
docs/usage/key-concepts/dashboard.md Outdated Show resolved Hide resolved
lib/workers/repository/dependency-dashboard.ts Show resolved Hide resolved
lib/workers/repository/dependency-dashboard.ts Outdated Show resolved Hide resolved
rarkins and others added 2 commits June 16, 2024 12:06
@rarkins @HonkingGoose
Update docs/usage/key-concepts/dashboard.md
025e2f2 
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@rarkins @HonkingGoose
Update lib/workers/repository/dependency-dashboard.ts
40d9909 
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@rarkins @HonkingGoose
Update dashboard.md
1c5d89f 
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
viceice
viceice previously approved these changes Jun 16, 2024
View reviewed changes
HonkingGoose
HonkingGoose suggested changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder that you still need to:

  • add a screenshot
  • or rework the text so it uses a Material for MkDocs style admonition, and make sure the prettier linter ignores the block

lib/workers/repository/dependency-dashboard.ts Outdated Show resolved Hide resolved
lib/workers/repository/dependency-dashboard.ts Outdated Show resolved Hide resolved
@rarkins @HonkingGoose
Apply suggestions from code review
fb66f81 
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@rarkins rarkins enabled auto-merge June 17, 2024 09:47
@rarkins rarkins requested review from viceice and secustor June 17, 2024 09:47
HonkingGoose
HonkingGoose approved these changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing, then good to go.

docs/usage/key-concepts/dashboard.md Show resolved Hide resolved
@rarkins rarkins added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit 03c034f Jun 17, 2024
37 checks passed
@rarkins rarkins deleted the feat/5098-deprecated-dependency-dashboard branch June 17, 2024 10:58
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.410.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb left review comments

@viceice viceice viceice approved these changes

@HonkingGoose HonkingGoose HonkingGoose approved these changes

@secustor secustor Awaiting requested review from secustor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-enable deprecated dependency warnings
6 participants
@rarkins @renovate-release @ljharb @viceice @secustor @HonkingGoose