Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(got): configurable timeout #3640

Closed
viceice opened this issue May 7, 2019 · 1 comment
Closed

feat(got): configurable timeout #3640

viceice opened this issue May 7, 2019 · 1 comment
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@viceice
Copy link
Member

viceice commented May 7, 2019

What would you like Renovate to be able to do?
We should add a configurable timeout to the got requests, otherwise they can stuck infinite.
It should be configurable, because some hosts could be to slow for the default timeout.

Describe the solution you'd like
Set a default timeout of 30s as timeout and allow overriding it with host-rules.

Describe alternatives you've considered
No alternate posible.

Additional context
As fast fix we add hard coded timeout of 30s.
@viceice viceice mentioned this issue May 7, 2019
Merged
@rarkins rarkins added type:feature Feature (new functionality) needs-requirements priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others labels May 7, 2019
@renovate-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 18.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@viceice @rarkins @renovate-bot