Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(yarn): support yarn offline mirror #4102

Merged
merged 1 commit into from
Jul 17, 2019

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Jul 17, 2019

Look for .yarnrc in same directory as yarn.lock. If found, look for yarn-offine-mirror line and check that folder for changes.

Closes #1452

Look for .yarnrc in same directory as yarn.lock. If found, look for yarn-offine-mirror line and check that folder for changes.

Closes #1452
@rarkins rarkins merged commit 7fc1207 into master Jul 17, 2019
@rarkins rarkins deleted the feat/1452-yarn-offline-mirror branch July 17, 2019 07:13
@renovate-bot
Copy link
Collaborator

🎉 This PR is included in version 19.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mrtnzlml
Copy link

@rarkins Hi, this still doesn't work for us. But I have a hard time to figure out what is wrong. This is the log from our CI:

$ yarn install --offline --frozen-lockfile
yarn install v1.17.3
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
error Can't make a request in offline mode ("https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.103.0.tgz")
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

BUT this MR contains the .tgz archive, updated yarn.lock and all relevant package.json files. I tried to checkout this MR and install it locally which indeed does something and at the end the archive is modified but git diff is not helping me very much:

diff --git a/.yarn/cache/flow-bin-0.103.0.tgz b/.yarn/cache/flow-bin-0.103.0.tgz
index 1a637c55..34828197 100644
Binary files a/.yarn/cache/flow-bin-0.103.0.tgz and b/.yarn/cache/flow-bin-0.103.0.tgz differ
(END)

Do you have any idea what is wrong? Every MR from renovatebot fails like this. 🤔

@mrtnzlml
Copy link

Mm, one more clue maybe: I returned back to master and deleted the branch to continue working on something else. Then I returned back, checked out the MR again and there was no problem suddenly (yarn install was happy). So I deleted local Yarn cache (yarn cache clean) and tried again. This time I got this error:

yarn install v1.17.3
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
error https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.103.0.tgz: Integrity check failed for "flow-bin" (computed integrity doesn't match our records, got "sha512-kTWKyK819ZuRxHBrkfup49QcMHvmIay8zgjph9e30/Xb49mcNUyQm+VLKipSeh6lWZsJ1S/F4jwJx8CwP9ZY6w==")

Something is definitely not OK with these MRs. Thanks for having a look.

@rarkins
Copy link
Collaborator Author

rarkins commented Jul 19, 2019

Created new issue #4126 to track in

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support yarn offline mirror
3 participants