Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle parsing of invalid YAML in .travis.yml #4191

Merged
merged 3 commits into from
Jul 27, 2019
Merged

fix: handle parsing of invalid YAML in .travis.yml #4191

merged 3 commits into from
Jul 27, 2019

Conversation

nihalwasheretoo
Copy link
Contributor

Closes #2492

@nihalwasheretoo
Copy link
Contributor Author

@rarkins finally it's ready

@rarkins
Copy link
Collaborator

rarkins commented Jul 26, 2019

@nihal9ns you deleted yarn.lock

viceice
viceice requested changes Jul 26, 2019
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not remove yarn.lock

@nihalwasheretoo
Copy link
Contributor Author

@rarkins @viceice sorry about that, didn't realise. Added yarn.lock which is currently in the master branch.

viceice
viceice approved these changes Jul 26, 2019
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rarkins rarkins merged commit a6b48f6 into renovatebot:master Jul 27, 2019
@renovate-bot
Copy link
Collaborator

🎉 This PR is included in version 19.16.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle/skip invalid YML in .travis.yml
4 participants
@nihalwasheretoo @rarkins @renovate-bot @viceice