Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bitbucket): fix PR url in master issue #4195

Merged
merged 1 commit into from
Jul 27, 2019

Conversation

ZyanKLee
Copy link
Contributor

@ZyanKLee ZyanKLee commented Jul 26, 2019

bitbucket cloud has its PRs at /$teamName/$repoName/pull-requests/$prId
without this PR the url in master issues was /$teamName/$repoName/src/pull/$prId

Added another replace() to getPrBody() similar to the one used for gitlab, to replace ../pull with ../../pull-requests to have the URL without src and with the -requests part.
This function is then used to parse the issue body before it is POST'ed to bitbucket API.

Closes #4179

bitbucket cloud has its PRs at 
`/$teamName/$repoName/pull-requests/$prId`
@CLAassistant
Copy link

CLAassistant commented Jul 26, 2019

CLA assistant check
All committers have signed the CLA.

@rarkins rarkins merged commit 9e5ea71 into renovatebot:master Jul 27, 2019
@renovate-bot
Copy link
Collaborator

🎉 This PR is included in version 19.16.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ZyanKLee ZyanKLee deleted the bugfix/bitbucket-issue-prurl branch August 7, 2019 14:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bitbucket-cloud: masterIssue PR-urls are wrong
4 participants