fix(html-sanitize): Sanitize HTML comments in PR #4285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakeshtembhurne
force-pushed
the
feat/html-sanitize
branch
2 times, most recently
from
281ff7a
to
577f81f
Compare
viceice
reviewed
Aug 14, 2019
| @@ -964,6 +964,7 @@ export function getPrBody(input: string) { | |||
| .replace(/<\/?summary>/g, '**') | |||
| .replace(/<\/?details>/g, '') | |||
| .replace(new RegExp(`\n---\n\n.*?<!-- .*?-rebase -->.*?(\n|$)`), '') | |||
| .replace(new RegExp('<!--.*-->', 'g'), '') | |||
There was a problem hiding this comment.
Shouldn't we be non greedy here '<!--.*?-->' ?
otherwise we would replace all:
<!-- comment -->
Text
<!-- other comment -->
Suggested change
| .replace(new RegExp('<!--.*-->', 'g'), '') | |
| .replace(new RegExp('<!--.*?-->', 'g'), '') |
There was a problem hiding this comment.
Yeah, you're right. I will make sure that it works well with such scenarios as well.
There was a problem hiding this comment.
I've added the suggestion. if you like you can take it 😄
There was a problem hiding this comment.
It's a good suggestion. Happy to use it.
rakeshtembhurne
force-pushed
the
feat/html-sanitize
branch
from
577f81f
to
3f4b326
Compare
Sanitizes HTML comments inside PR body for BitBucket server. Includes snapshots for the tests. Refer renovatebot#3715
rakeshtembhurne
force-pushed
the
feat/html-sanitize
branch
from
3f4b326
to
6163686
Compare
|
🎉 This PR is included in version 19.24.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sanitizes HTML comments inside PR body for BitBucket server.
Closes #3715