Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More options needed when setting autocomplete on azure devops. #4514

Closed
stocksr opened this issue Sep 18, 2019 · 3 comments · Fixed by #4584
Closed

More options needed when setting autocomplete on azure devops. #4514

stocksr opened this issue Sep 18, 2019 · 3 comments · Fixed by #4584
Assignees
Labels
platform:azure Azure DevOps platform priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@stocksr
Copy link

stocksr commented Sep 18, 2019

What would you like Renovate to be able to do?
Control the options used when a dev ops pull request auto completes, currently this is hard coded to squash merge and we don't use squash merges in our setup. (this is a policy decision that we are not changing)

Describe the solution you'd like
I would like an option that lets me control the options passed in this azure api call.

completionOptions: {

specifically the merge type.
see : here for the options.
https://github.com/microsoft/azure-devops-node-api/blob/f21b5bf4c9b49d53c81eedf771ccd4165b58d1d0/api/interfaces/GitInterfaces.ts#L1732

Describe alternatives you've considered
Not using auto complete

Additional context

@rarkins rarkins added platform:azure Azure DevOps platform type:feature Feature (new functionality) needs-requirements priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others labels Sep 18, 2019
@JamieMagee
Copy link
Contributor

@stocksr Thanks for opening the issue. Would a solution similar to how we manage merges for GitHub work? See here. We iterate over all merge types until we find one that works? We can use the Policy Configurations - Get API to retrieve branch policies.

@stocksr
Copy link
Author

stocksr commented Sep 19, 2019

That would definitely be better than the current behaviour, and would work for me as we only allow one type.

My only comment would be that the order you iterate might not work for everybody, I guess this boils down to opinionated vs configurable software, and I don't have a strong opinion either way in this case.

@JamieMagee
Copy link
Contributor

Yeah, I think having it as a configuration option is definitely the best way to do this, but I'd like to implement that for all platforms—not just Azure DevOps.

I think the quickest solution to solve your immediate problem is to implement selection of merge type the same as in GitHub, and then add a configuration option that works for all platforms.

@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 19.62.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform:azure Azure DevOps platform priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants