feat(schedule): Support month (M) in schedules

[cfra]

Compare the M part of the schedule parsed by later so that schedules like every Monday of February-April are handled correctly.

Fixes: #4831

[cfra]

As this seemed pretty easy, I thought I'd attempt to implement this one myself.

However, it's my first contribution attempt and it seems like I screwed up the implementation in some aspect, seeing that workers/branch/schedule › isScheduledNow(config) › rejects on months of year is failing.

From the coverage, it seems like the schedule is never checked withschedule.M set. However, testing this on a console, it seems like my test rule does result in schedule.M being set:

> parsedSchedule = later.parse.text("of January");
{ schedules: [ { M: [Array] } ], exceptions: [], error: -1 }
> parsedSchedule.schedules[0].M
[ 1 ]
> !!parsedSchedule.schedules[0].M
true

If you find the time, could you be so kind to provide me with a pointer how I can find the cause of this issue?

[rarkins]

@cfra I suspect it's because you need to add M to this list:

renovate/lib/workers/branch/schedule.ts

Line 52 in 4a62a72

s => s.d !== undefined || s.D || s.t_a !== undefined || s.t_b

[cfra]

Thank you for spotting this. The tests seem to be fine now.

[rarkins]

I forget - and clearly didn't document - why some checks were !== undefined while others were just simple like s.t_b. I don't suppose you looked into this while deciding what to do for s.M ?

[cfra]

I have to admit I fell for cargo-cult here and copied the check applied to s.D without real understanding. 😬

[renovate-release]

🎉 This PR is included in version 19.68.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀