fix(pnpm): stop ignore pnpmfile #4845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this allows for execution of untrusted code then we'd only want to enable if the repo is set to a high trust level. Are you running self-hosted or in the app? |
|
Self-hosted |
|
In that case, can you refactor it so that it's similar to renovate/lib/manager/composer/artifacts.ts Lines 126 to 128 in 24a9e29 |
|
Sure |
|
Done |
rarkins
reviewed
Nov 21, 2019
| @@ -92,7 +92,9 @@ export async function generateLockFile( | |||
| cmd += ' install'; | |||
| cmd += ' --lockfile-only'; | |||
| cmd += ' --ignore-scripts'; | |||
| cmd += ' --ignore-pnpmfile'; | |||
| if (global.trustLevel !== 'high') { | |||
| cmd += ' --ignore-pnpmfile'; | |||
There was a problem hiding this comment.
To be consistent with other managers, we should include --ignore-scripts here too.
|
Thanks @Djaler |
|
🎉 This PR is included in version 19.67.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pnpfile contains hooks that can be required to install packages correct. And because of this it shouldn't be ignored by default