Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(maven): Lookup for additional info for latest stable version #4970

Merged

Conversation

zharinov
Copy link
Collaborator

Hopefully closes #4617

@zharinov zharinov changed the title feat(maven): Lookup for additional info for latest stable version feat(maven): Lookup for additional info for latest stable version [WIP] Dec 11, 2019
@rarkins
Copy link
Collaborator

rarkins commented Dec 11, 2019

Any risk that this breaks something?

@zharinov
Copy link
Collaborator Author

Minimal, since getLatestStableVersion is being used only for additional info retrieval (source url, scm and homepage)

@zharinov zharinov changed the title feat(maven): Lookup for additional info for latest stable version [WIP] feat(maven): Lookup for additional info for latest stable version Dec 11, 2019
@zharinov
Copy link
Collaborator Author

Just let me test it in couple sample repos

@zharinov
Copy link
Collaborator Author

As expected, it performs simlilar to master except it takes meta-info from latest stable, not just latest.

@rarkins rarkins merged commit 75943de into renovatebot:master Dec 11, 2019
@rarkins rarkins deleted the fix/maven-datasource-stable-dep-info branch December 11, 2019 13:31
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 19.80.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renovate tries to wrongly download maven SNAPSHOTs
3 participants