Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly log pkgUrl in case of error #4972

Merged
merged 1 commit into from
Dec 13, 2019
Merged

fix: properly log pkgUrl in case of error #4972

merged 1 commit into from
Dec 13, 2019

Conversation

bagage
Copy link
Contributor

@bagage bagage commented Dec 11, 2019 •
edited

Currently when there is an error for some maven dependency, the pkgUrl context in the log is empty (because its type is url.URL).

Forcing toString() to display it properly in that case too.

@rarkins
Copy link
Collaborator

rarkins commented Dec 11, 2019

pkgUrl is not a special term for Renovate's logs so could we instead convert it in the top of the catch (e.g. const failedUrl = pkgUrl.toString()) and then reference that in the logs?

viceice
viceice requested changes Dec 13, 2019
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bagage Please carry out suggested changes

@bagage
Copy link
Contributor Author

bagage commented Dec 13, 2019

I updated the code accordingly :).

@bagage bagage force-pushed the fix-logging branch 2 times, most recently from 0a7943b to 1d701f5 Compare December 13, 2019 08:44
viceice
viceice requested changes Dec 13, 2019
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please run yarn prettier-fix

@rarkins rarkins merged commit b357aab into renovatebot:master Dec 13, 2019
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 19.81.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bagage @rarkins @renovate-release @viceice