Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(composer): Use centralized docker execution #5060

Merged
merged 2 commits into from Jan 27, 2020
Merged

feat(composer): Use centralized docker execution #5060

merged 2 commits into from Jan 27, 2020

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Dec 24, 2019 •
edited by viceice

ref #2863

@viceice viceice changed the title refactor(composer): Use centralized docker execution refactor(composer): Use centralized docker execution [WIP] Jan 7, 2020
@viceice
Copy link
Member

viceice commented Jan 7, 2020

needs deconflicting

@zharinov zharinov changed the title refactor(composer): Use centralized docker execution [WIP] refactor(composer): Use centralized docker execution Jan 10, 2020
@zharinov zharinov changed the title refactor(composer): Use centralized docker execution refactor(composer): Use centralized docker execution [WIP] Jan 10, 2020
@zharinov zharinov force-pushed the refactor/composer-docker branch 3 times, most recently from fd64216 to ca0c6a4 Compare January 18, 2020 15:09
@zharinov zharinov changed the title refactor(composer): Use centralized docker execution [WIP] refactor(composer): Use centralized docker execution Jan 18, 2020
@zharinov
Copy link
Collaborator Author

Ready for review

viceice
viceice previously approved these changes Jan 18, 2020
View reviewed changes
@rarkins
Copy link
Collaborator

rarkins commented Jan 18, 2020

I think the cache master volume should already be mapped by the util function so not necessary here

@rarkins rarkins changed the title refactor(composer): Use centralized docker execution feat(composer): Use centralized docker execution Jan 27, 2020
@rarkins rarkins merged commit f286aa3 into renovatebot:master Jan 27, 2020
@rarkins rarkins deleted the refactor/composer-docker branch January 27, 2020 13:18
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 19.112.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins left review comments

@viceice viceice viceice left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zharinov @viceice @rarkins @renovate-release