Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gradle): Support template expression for version variables in gradle #5195

Merged

Conversation

jGleitz
Copy link
Contributor

@jGleitz jGleitz commented Jan 20, 2020

Supports using string interpolation for the version if using Gradle’s map or named arguments syntax.

As the other regexes, the matching is quite loose and will match some (mostly syntactically invalid) other cases. But I think they will not create relevant false positives.

Also adds support for Groovy’s three-quotes-string (''' and """). Supporting them properly was required to differentiate correctly between literals and variables. I then added the support throughout the file.

Closes #4838

@jGleitz jGleitz force-pushed the feature/gradle-template-expression branch from a8f112b to 0257ffa Compare January 20, 2020 13:22
@jGleitz jGleitz changed the title Support template expression for version variables in gradle feat(gradle): Support template expression for version variables in gradle Jan 20, 2020
@rarkins rarkins requested a review from ikesyo January 20, 2020 14:40
@rarkins rarkins merged commit c1ee1ef into renovatebot:master Jan 21, 2020
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 19.103.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jGleitz jGleitz deleted the feature/gradle-template-expression branch February 6, 2020 10:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renovate updates versions in build.gradle rather than gradle.properties
3 participants