-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(platform): Filter out non-Renovate PRs with same branch #5211
fix(platform): Filter out non-Renovate PRs with same branch #5211
Conversation
@zharinov what tests have you been able to do so far? e.g. were you able to reproduce the problem in old code then see it's fixed in new? |
Shouldn't we try to fetch only our PR's? Then we don't need that check. |
Right now we fetch all open ones in case one is a Renovate reconfiguration PR that we need to validate |
I’m tempted to deprecate that capability and make it a separate module to keep core renovate simpler |
I tested on this example, it updates different PRs depending on master vs fix branch. I also validated this result with debugger run. |
|
Okay, seems like it's ready for review |
🎉 This PR is included in version 19.111.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes #5188