Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): Filter out non-Renovate PRs with same branch #5211

Merged

Conversation

zharinov
Copy link
Collaborator

Closes #5188

@rarkins
Copy link
Collaborator

rarkins commented Jan 22, 2020

@zharinov what tests have you been able to do so far? e.g. were you able to reproduce the problem in old code then see it's fixed in new?

@viceice
Copy link
Member

viceice commented Jan 24, 2020

Shouldn't we try to fetch only our PR's? Then we don't need that check.

@rarkins
Copy link
Collaborator

rarkins commented Jan 24, 2020

Right now we fetch all open ones in case one is a Renovate reconfiguration PR that we need to validate

@rarkins
Copy link
Collaborator

rarkins commented Jan 24, 2020

I’m tempted to deprecate that capability and make it a separate module to keep core renovate simpler

@zharinov
Copy link
Collaborator Author

@zharinov what tests have you been able to do so far? e.g. were you able to reproduce the problem in old code then see it's fixed in new?

I tested on this example, it updates different PRs depending on master vs fix branch. I also validated this result with debugger run.

@rarkins
Copy link
Collaborator

rarkins commented Jan 25, 2020

  • Need to check that this doesn't break "forkMode" because Renovate's PRs come from another repo

@zharinov
Copy link
Collaborator Author

Okay, seems like it's ready for review

@rarkins rarkins merged commit 514fdbd into renovatebot:master Jan 27, 2020
@rarkins rarkins deleted the fix/github-platform-get-pr-by-branch branch January 27, 2020 12:45
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 19.111.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getBranchPr gets confused by other PRs
4 participants