Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle build fails if io.spring.dependency-management plugin is used #5398

Closed
timkingman opened this issue Feb 6, 2020 · 3 comments · Fixed by #5407
Closed

Gradle build fails if io.spring.dependency-management plugin is used #5398

timkingman opened this issue Feb 6, 2020 · 3 comments · Fixed by #5407
Labels
manager:gradle Gradle package manager priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:bug Bug fix of existing functionality

Comments

@timkingman
Copy link

What Renovate type are you using?

On-prem docker (tag 19), also tested on GitHub Hosted

Describe the bug

Docker Renovate started failing against a gradle Spring Boot project yesterday.

Did you see anything helpful in debug logs?

Execution failed for task ':renovate'
> No such property: url for class: org.gradle.plugin.use.internal.PluginDependencyResolutionServices$PluginArtifactRepository

Test repo: https://github.com/timkingman/renovate-spring-deps-test
Same error in hosted job ID: 138693132

To Reproduce

Test repo https://github.com/timkingman/renovate-spring-deps-test was created by gradle init and adding to build.gradle:

plugins {
	id 'io.spring.dependency-management' version '1.0.9.RELEASE'
}

Additional context

It looks like #5382 introduced this error, because I don't see it when running version 19.120.3. I did some testing with --persist-repo-data in the docker container and changing renovate-plugin.gradle:13-14 seemed to avoid this error:

           .collect { it.hasProperty("url") ? "$it.url" : "" }
           .findAll { it && !it.startsWith('file:') }
@JamieMagee JamieMagee added manager:gradle Gradle package manager priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others ready labels Feb 7, 2020
@rarkins rarkins added the type:bug Bug fix of existing functionality label Feb 7, 2020
@rarkins
Copy link
Collaborator

rarkins commented Feb 7, 2020

@jGleitz @ikesyo do you have any advice on what we should do here? e.g. temporarily roll back #5382, or should we roll forward and patch the problem elsewhere?

@jGleitz
Copy link
Contributor

jGleitz commented Feb 7, 2020

Since @timkingman has kindly provided a repository to reproduce this bug, I think that I can provide a fix soon.

So I think we don’t have to roll back.

@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 19.126.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
manager:gradle Gradle package manager priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:bug Bug fix of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants