Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle expired hosts #5463

Closed
rarkins opened this issue Feb 12, 2020 · 1 comment
Closed

Gracefully handle expired hosts #5463

rarkins opened this issue Feb 12, 2020 · 1 comment
Labels
manager:maven Maven (Java) package manager priority-2-high Bugs impacting wide number of users or very important features

Comments

@rarkins
Copy link
Collaborator

rarkins commented Feb 12, 2020

What would you like Renovate to be able to do?

Gracefully handle this type of error:

{
    "level": 40,
    "repository": "pac4j/play-pac4j",
    "failedUrl": "https://scala-tools.org/repo-releases/com/typesafe/play/play_2.12/maven-metadata.xml",
    "err": {
        "name": "RequestError",
        "code": "ERR_TLS_CERT_ALTNAME_INVALID",
        "hostname": "scala-tools.org",
        "method": "GET",
        "path": "/repo-releases/com/typesafe/play/play_2.12/maven-metadata.xml",
        "protocol": "https:",
        "url": "https://scala-tools.org/repo-releases/com/typesafe/play/play_2.12/maven-metadata.xml",
        "gotOptions": {
            "path": "/repo-releases/com/typesafe/play/play_2.12/maven-metadata.xml",
            "protocol": "https:",
            "hostname": "scala-tools.org",
            "hash": "",
            "search": "",
            "pathname": "/repo-releases/com/typesafe/play/play_2.12/maven-metadata.xml",
            "href": "https://scala-tools.org/repo-releases/com/typesafe/play/play_2.12/maven-metadata.xml",
            "headers": {
                "user-agent": "Renovate Bot (GitHub App 2740)",
                "accept-encoding": "gzip, deflate"
            },
            "hooks": {
                "beforeError": [],
                "init": [],
                "beforeRequest": [],
                "beforeRedirect": [
                    null
                ],
                "beforeRetry": [],
                "afterResponse": []
            },
            "retry": {
                "methods": {},
                "statusCodes": {},
                "errorCodes": {}
            },
            "decompress": true,
            "throwHttpErrors": true,
            "followRedirect": true,
            "stream": false,
            "form": false,
            "json": false,
            "cache": false,
            "useElectronNet": false,
            "hostType": "maven",
            "method": "GET"
        },
        "message": "Hostname/IP does not match certificate's altnames: Host: scala-tools.org. is not in the cert's altnames: DNS:*.user.fm, DNS:user.fm",
        "stack": "RequestError: Hostname/IP does not match certificate's altnames: Host: scala-tools.org. is not in the cert's altnames: DNS:*.user.fm, DNS:user.fm\n    at ClientRequest.request.once.error (/home/ubuntu/renovateapp/node_modules/got/source/request-as-event-emitter.js:178:14)\n    at Object.onceWrapper (events.js:286:20)\n    at ClientRequest.emit (events.js:203:15)\n    at ClientRequest.EventEmitter.emit (domain.js:448:20)\n    at ClientRequest.origin.emit.args (/home/ubuntu/renovateapp/node_modules/@szmarczak/http-timer/source/index.js:37:11)\n    at TLSSocket.socketErrorListener (_http_client.js:392:9)\n    at TLSSocket.emit (events.js:198:13)\n    at TLSSocket.EventEmitter.emit (domain.js:448:20)\n    at emitErrorNT (internal/streams/destroy.js:91:8)\n    at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)"
    },
    "msg": "Unknown error",
    "time": "2020-02-12T08:49:37.500Z"

Describe the solution you'd like

Instead of "Unknown error" it should have a known type so that it can be ignored. In this case the host is defunct.

@rarkins rarkins added ready priority-2-high Bugs impacting wide number of users or very important features manager:maven Maven (Java) package manager labels Feb 12, 2020
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 19.131.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
manager:maven Maven (Java) package manager priority-2-high Bugs impacting wide number of users or very important features
Projects
None yet
Development

No branches or pull requests

2 participants