New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gitlab): add merge method check #5567
Conversation
No live test yet. Maybe safe anyway? |
I just realized something - we need to check when this field was introduced. Otherwise if there's older GitLab versions which don't support the field then they'll start always rebasing. |
ok, i'll look at the api |
https://docs.gitlab.com/ee/policy/maintenance.html looks like they only support the latest 3 versions. I can't find when try introduced the property, but i think it was long time ago. (at least readonly) but to be safe, we can check existance. |
🎉 This PR is included in version 19.148.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
looks like https://gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/14272 introduced it in version 10.1. Older versions have had other properties. Should we support older versions than 10.1, which are no longer supported? |
We should support whatever GitLab says is supported, but ideally not break older stuff also if we can avoid it. |
We do not break it, we only force a rebase if we fall behind on version less than 10.1 🙈 |
a simple fix for older versions would be |
If
merge_method
is notmerge
we need to force rebase our branches.Closes #5565