Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do nothing if new commit and check required #5594

Merged
merged 6 commits into from
Mar 3, 2020
Merged

Conversation

viceice
Copy link
Member

@viceice viceice commented Feb 28, 2020

We do not try to automerge nor create a pr if we pushed a new branch commit.

This is now enforced when requiredStatusChecks != null and prCreation !== 'immediate'.
So the user has actively changed the default config and want's all status checks passed.
The current implementation add renovate status checks after commit, so it can happen that only our statuses are reported and successful.

fixes: #4511

@viceice viceice requested a review from rarkins February 28, 2020 13:59
@viceice viceice changed the title fix: do nothing if new commit and check required fix: do nothing if new commit and check required (WIP) Feb 28, 2020
@viceice viceice changed the title fix: do nothing if new commit and check required (WIP) fix: do nothing if new commit and check required Feb 28, 2020
@rarkins rarkins merged commit 69c8dca into master Mar 3, 2020
@rarkins rarkins deleted the fix/pending-status branch March 3, 2020 10:52
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2020

🎉 This PR is included in version 19.154.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set Assignees and Reviewers after stability days
2 participants