Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(maven): Use fallback maven registry #5613

Merged

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Mar 1, 2020

Closes #5609


export const MAVEN_REPO = 'https://repo.maven.apache.org/maven2';
export const MAVEN_REPO_DEPRECATED = 'https://central.maven.org/maven2';
export const CLOJARS_REPO = 'https://clojars.org/repo';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://repo.clojars.org? See https://clojars.org/.

Shouldn't this be moved to deps-edn, because it's only used there?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not only, it's also used withleiningen

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we simplify any logic by splitting the maven datasource into multiple?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think so, sbt already is separate, but clojure differs only with additional registryUrl

@rarkins
Copy link
Collaborator

rarkins commented Mar 1, 2020

What’s the level of risk of this PR? Eg Needs any more testing? Should be watched closely after merge? Etc

@zharinov
Copy link
Collaborator Author

zharinov commented Mar 1, 2020

For gradle it can lead to more traffic with Maven central repo (for cases when it currently logs warn and returns null). Also there is some probability of new errors, but other JVM-based managers should perform as usual.

@rarkins rarkins merged commit 0691b13 into renovatebot:master Mar 2, 2020
@rarkins rarkins deleted the fix/maven-datasource-fallback-registry branch March 2, 2020 08:08
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2020

🎉 This PR is included in version 19.153.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"No repositories defined for.." warnings
3 participants