-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(maven): Use fallback maven registry #5613
fix(maven): Use fallback maven registry #5613
Conversation
|
||
export const MAVEN_REPO = 'https://repo.maven.apache.org/maven2'; | ||
export const MAVEN_REPO_DEPRECATED = 'https://central.maven.org/maven2'; | ||
export const CLOJARS_REPO = 'https://clojars.org/repo'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://repo.clojars.org
? See https://clojars.org/.
Shouldn't this be moved to deps-edn
, because it's only used there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not only, it's also used withleiningen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we simplify any logic by splitting the maven datasource into multiple?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think so, sbt
already is separate, but clojure differs only with additional registryUrl
What’s the level of risk of this PR? Eg Needs any more testing? Should be watched closely after merge? Etc |
For gradle it can lead to more traffic with Maven central repo (for cases when it currently logs |
🎉 This PR is included in version 19.153.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes #5609