Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(azure): null exception updating comment #5624

Merged
merged 2 commits into from
Mar 3, 2020

Conversation

lukeapage
Copy link
Contributor

I just came across this during my daily usage - its in code I wrote - I hadn't realized the content can be undefined.
I can write a test later if needed, just raising this now so I don't forget.

@lukeapage lukeapage changed the title Fix: azure null exception updating comment fix(azure): null exception updating comment Mar 2, 2020
@JamieMagee JamieMagee self-requested a review March 2, 2020 20:54
JamieMagee
JamieMagee previously approved these changes Mar 2, 2020
Copy link
Contributor

@JamieMagee JamieMagee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lib/platform/azure/index.ts Outdated Show resolved Hide resolved
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs lint-fix run

Co-Authored-By: Michael Kriese <michael.kriese@visualon.de>
@rarkins rarkins merged commit 30a3c9e into renovatebot:master Mar 3, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2020

🎉 This PR is included in version 19.154.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants