Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(internal): got coverage #5716

Merged
merged 3 commits into from Mar 17, 2020
Merged

chore(internal): got coverage #5716

merged 3 commits into from Mar 17, 2020

Conversation

viceice
Copy link
Member

@viceice viceice commented Mar 13, 2020

Test coverage for utils/got nearly complete.

Only two ignores left. I think they are ok.

rarkins
rarkins reviewed Mar 13, 2020
View reviewed changes
lib/util/got/cache-get.ts Outdated Show resolved Hide resolved
lib/util/got/got.spec.ts Show resolved Hide resolved
lib/util/got/host-rules.ts Show resolved Hide resolved
@viceice viceice requested a review from rarkins March 17, 2020 10:33
@rarkins rarkins merged commit c03e740 into master Mar 17, 2020
@rarkins rarkins deleted the chore/got-coverage branch March 17, 2020 11:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamieMagee JamieMagee Awaiting requested review from JamieMagee

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@viceice @rarkins