Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(go): detect submodules #5796

Merged
merged 7 commits into from
Mar 27, 2020
Merged

fix(go): detect submodules #5796

merged 7 commits into from
Mar 27, 2020

Conversation

mangas
Copy link
Contributor

@mangas mangas commented Mar 27, 2020 •
edited

Closes #5795

@CLAassistant
Copy link

CLAassistant commented Mar 27, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@mangas
Copy link
Contributor Author

mangas commented Mar 27, 2020

@viceice would you be able to review and expedite this please?

viceice
viceice requested changes Mar 27, 2020
View reviewed changes
lib/datasource/go/index.spec.ts Outdated Show resolved Hide resolved
lib/datasource/go/index.ts Outdated Show resolved Hide resolved
lib/datasource/go/index.ts Outdated Show resolved Hide resolved
mangas and others added 4 commits March 27, 2020 09:54
@mangas
fix fallback test
55760c0
@mangas
Merge branch 'fix-5795' of github.com:mangas/renovate into fix-5795
26621fd
@mangas @viceice
Update lib/datasource/go/index.ts
7320e2e 
Co-Authored-By: Michael Kriese <michael.kriese@visualon.de>
@mangas @viceice
Update lib/datasource/go/index.ts
1903cfe 
Co-Authored-By: Michael Kriese <michael.kriese@visualon.de>
@viceice viceice changed the title fix 5795 fix: detect go submodules Mar 27, 2020
@viceice viceice changed the title fix: detect go submodules fix(go): detect submodules Mar 27, 2020
viceice
viceice approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viceice viceice requested a review from rarkins March 27, 2020 10:24
@rarkins rarkins merged commit 6cbd4a7 into renovatebot:master Mar 27, 2020
@rarkins
Copy link
Collaborator

rarkins commented Mar 27, 2020

Thanks, @mangas !

@mangas mangas deleted the fix-5795 branch March 27, 2020 10:26
ViralRuparel pushed a commit to ViralRuparel/renovate that referenced this pull request Mar 29, 2020
@mangas @viceice @ViralRuparel
fix(go): detect submodules (renovatebot#5796)
b4ee50a 
Co-Authored-By: Michael Kriese <michael.kriese@visualon.de>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Goland submodules version not detected
4 participants
@mangas @CLAassistant @rarkins @viceice