fix: undefined ignoreScripts config option #5811
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4567 I had an issue in my repository. We were using
trustLevel: high
but we did not want to execute post-scripts after bumping composer dependencies. TheignoreScripts: true
option was added in #4963 π Unfortunately I could not get it to work. Initially, I thought my config was wrong and I created a config-help issue (renovatebot/config-help#522).I had some time now to debug the issue. This seemed to be the issue:
"ignoreScripts": true,
to myrenovate.json
filedist/manager/composer/artifacts.js
to print out the value ofconfig.ignoreScripts
ignoreScripts
at all π€ it printedundefined
as the value for ignoreScripts in the config π .If I remove the
stage: 'package'
fromignoreScripts
β just like other options such asignoreNpmrcFile
β it works andconfig.ignoreScripts
returnstrue
and composer succesfully adds the--no-scripts
argument π