Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undefined ignoreScripts config option #5811

Merged
merged 3 commits into from
Mar 29, 2020

Conversation

jessedobbelaere
Copy link
Contributor

@jessedobbelaere jessedobbelaere commented Mar 28, 2020

In #4567 I had an issue in my repository. We were using trustLevel: high but we did not want to execute post-scripts after bumping composer dependencies. The ignoreScripts: true option was added in #4963 πŸ™Œ Unfortunately I could not get it to work. Initially, I thought my config was wrong and I created a config-help issue (renovatebot/config-help#522).

I had some time now to debug the issue. This seemed to be the issue:

  • Added "ignoreScripts": true, to my renovate.json file
  • Started a Docker container locally, but adding some debug statements in dist/manager/composer/artifacts.js to print out the value of config.ignoreScripts
  • Ran renovate on a private repo. Result was that config did not even have the property ignoreScripts at all πŸ€” it printed undefined as the value for ignoreScripts in the config πŸ‘Ž .

If I remove the stage: 'package' from ignoreScripts – just like other options such as ignoreNpmrcFile – it works and config.ignoreScripts returns true and composer succesfully adds the --no-scripts argument πŸŽ‰

@jessedobbelaere jessedobbelaere changed the title Fix undefined ignoreScripts config option fix: undefined ignoreScripts config option Mar 28, 2020
@jessedobbelaere
Copy link
Contributor Author

jessedobbelaere commented Mar 28, 2020

One unit test failing but it's ok, looks like the snapshot needs to be updated because the ignoreScripts option appeared in the config now. Not sure yet how to update the snapshot πŸ‘€

image

@viceice
Copy link
Member

viceice commented Mar 28, 2020

Look at the jest summary after all tests done. There is a suggestion how to update snapshots. πŸ™ƒ

@rarkins rarkins merged commit 51337c4 into renovatebot:master Mar 29, 2020
@renovate-release
Copy link
Collaborator

πŸŽ‰ This PR is included in version 19.185.2 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

@jessedobbelaere jessedobbelaere deleted the fix-ignore-scripts-option branch March 29, 2020 12:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants