test(gradle): stop mocking the file system #5826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jGleitz
commented
Mar 29, 2020
JamieMagee
reviewed
Mar 30, 2020
lib/manager/gradle/index.spec.ts
Outdated
Comment on lines
36
to
46
| const replacingSerializer = ( | ||
| search: string, | ||
| replacement: string | ||
| ): jest.SnapshotSerializerPlugin => ({ | ||
| test: value => typeof value === 'string' && value.includes(search), | ||
| serialize: (val, config, indent, depth, refs, printer) => { | ||
| const replaced = (val as string).replace(search, replacement); | ||
| return printer(replaced, config, indent, depth, refs); | ||
| }, | ||
| }); | ||
|
|
There was a problem hiding this comment.
This is a great idea. Could you extract it to test/utils.ts, as there are quite a few places we mock fs to get consistent path names, and this is a much better approach.
JamieMagee
previously approved these changes
Mar 30, 2020
viceice
requested changes
Mar 30, 2020
|
Done |
JamieMagee
approved these changes
Apr 3, 2020
|
🎉 This PR is included in version 19.192.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the mistake I made in #5806, I went ahead and replaced the file system mocking in the gradle tests with real file system accesses. From my point of view, the less we mock, the higher the probability that we find regressions. I could find no good reasons to mock the file system here. The mocking also depended on the precise
fsfunctions the code called, and on the order of those calls.Even though I think I have good reasons for this change, I realise that it is also a question of philosophy. So feel free to close this pull request if you prefer to keep the file system mocks.