fix(gradle): gradle wrapper execution files updates

[driver733]

Closes #3565

[driver733]

@viceice The build (yarn test) runs fine on my local machine(macOS Catalina), but fails on macos-latest CI. Can you take a look?

[viceice]

Java install is skipped on mac, so skip gradle tests or install java

[driver733]

@viceice Can you enable the Set up Java command in the CI?

[viceice]

Please skip gradle test if process.env.SKIP_JAVA_TESTS==='true'

https://github.com/renovatebot/renovate/blob/master/lib/manager/gradle/__testutil__/gradle.ts#L10
https://github.com/renovatebot/renovate/blob/master/lib/manager/gradle/gradle-updates-report.spec.ts#L23

[viceice]

Test needs fix

[viceice]

Soory, forgot to mentions that we need to add docker compatibillity. see below for invoking gradle with docker

renovate/lib/manager/gradle/index.ts

Lines 34 to 100 in a1c14f0

	function gradleWrapperFileName(config: ExtractConfig): string {
	if (
	os.platform() === 'win32' &&
	config.binarySource !== BinarySource.Docker
	) {
	return 'gradlew.bat';
	}
	return './gradlew';
	}
	async function prepareGradleCommandLine(
	config: ExtractConfig,
	cwd: string,
	gradlew: Stats | null
	): Promise<string> {
	const args = GRADLE_DEPENDENCY_REPORT_OPTIONS;
	const gradlewName = gradleWrapperFileName(config);
	/* eslint-disable no-bitwise */
	// istanbul ignore if
	if (gradlew?.isFile() === true) {
	// if the file is not executable by others
	if ((gradlew.mode & 0o1) === 0) {
	// add the execution permission to the owner, group and others
	await fs.chmod(upath.join(cwd, gradlewName), gradlew.mode | 0o111);
	}
	return `${gradlewName} ${args}`;
	}
	/* eslint-enable no-bitwise */
	return `gradle ${args}`;
	}
	export async function executeGradle(
	config: ExtractConfig,
	cwd: string,
	gradlew: Stats | null
	): Promise<void> {
	let stdout: string;
	let stderr: string;
	const timeout =
	config.gradle && config.gradle.timeout
	? config.gradle.timeout * 1000
	: undefined;
	const cmd = await prepareGradleCommandLine(config, cwd, gradlew);
	const execOptions: ExecOptions = {
	timeout,
	cwd,
	docker: {
	image: 'renovate/gradle',
	},
	};
	try {
	logger.debug({ cmd }, 'Start gradle command');
	({ stdout, stderr } = await exec(cmd, execOptions));
	} catch (err) /* istanbul ignore next */ {
	if (err.code === TIMEOUT_CODE) {
	const error = new DatasourceError(err);
	error.datasource = 'gradle';
	throw error;
	}
	logger.warn({ errMessage: err.message }, 'Gradle extraction failed');
	return;
	}
	logger.debug(stdout + stderr);
	logger.debug('Gradle report complete');

[viceice]

LGTM, looks like github has some trouble with the macos workers. So wee need to wait and hope it will be resolved tomorrow.

[driver733]

@viceice One macos build got cancelled due to the timeout. I guess increasing the timeout of the total build time can fix this problem.

[viceice]

see #5851

[renovate-release]

🎉 This PR is included in version 19.192.0 🎉

The release is available on:

• GitHub release
• 19.192.0

Your semantic-release bot 📦🚀