feat(internal): cached datasource lookups #5870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urce-cdnjs # Conflicts: # lib/datasource/cdnjs/index.spec.ts # lib/datasource/cdnjs/index.ts
|
Have some improvements for types, will do them later, currently on mobile only |
viceice
previously approved these changes
Apr 4, 2020
|
I split some of the work into #5871 |
# Conflicts: # lib/datasource/cdnjs/__fixtures__/KaTeX.json # lib/datasource/cdnjs/index.ts
…tebot/renovate into refactor/datasource-cdnjs # Conflicts: # lib/datasource/cdnjs/index.spec.ts
viceice
previously approved these changes
Apr 4, 2020
yes, I'll add. Doing some more refactoring |
|
I added some code docu, so ide users can see it and it would hopefully help them to use it. |
viceice
approved these changes
Apr 4, 2020
There was a problem hiding this comment.
See my commit for changes.
JsDoc types can't be linked: microsoft/TypeScript#35524
rarkins
changed the title
|
🎉 This PR is included in version 19.195.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the
cdnjsdatasource while abstracting away the task of caching. Also removes unnecessary getDigest.I took away some of the "safety" and null checks because I think this datasource should throw a DatasourceError for all errors except 404.
The important thing here is abstracting away the caching - I want to add this to all datasources if possible.