Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix types #5904

Merged
merged 20 commits into from
May 7, 2020
Merged

chore: fix types #5904

merged 20 commits into from
May 7, 2020

Conversation

viceice
Copy link
Member

@viceice viceice commented Apr 7, 2020 •
edited

Prepare renovate for noImplicitAny=true

risk to break: 0.01% 馃檭

@viceice
Copy link
Member Author

viceice commented Apr 7, 2020

Initial >1200 errors, now 303 errors to go.

@viceice viceice closed this Apr 8, 2020
@viceice viceice reopened this Apr 8, 2020
@viceice viceice marked this pull request as ready for review April 14, 2020 17:44
@viceice
Copy link
Member Author

viceice commented Apr 14, 2020

I think I'll do more in separate PR, so not too much to review

@JamieMagee
Copy link
Contributor

Not gonna lie, this is pretty hard to review 馃槄

But, like I've said before about these type changes, these incremental changes are great and get us closer to turning up the strictness 馃槃 Thank you @viceice

@viceice viceice requested a review from JamieMagee May 6, 2020 06:26
@viceice
Copy link
Member Author

viceice commented May 6, 2020

I think it's time for another review

@rarkins
Copy link
Collaborator

rarkins commented May 7, 2020

I think the semantic release error can be ignored - LGTM

@viceice
Copy link
Member Author

viceice commented May 7, 2020

yes, will only be enabled on master branches with #6116, so waiting for that first.

@JamieMagee
Copy link
Contributor

@viceice Ready for merge?

@viceice viceice merged commit 00c56d8 into master May 7, 2020
@viceice viceice deleted the chore/types branch May 7, 2020 08:23
@renovate-release
Copy link
Collaborator

馃帀 This PR is included in version 19.231.10 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamieMagee JamieMagee JamieMagee approved these changes

@rarkins rarkins rarkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@viceice @JamieMagee @rarkins @renovate-release