fix: add missing await statements #5918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamieMagee
force-pushed
the
fix/missing-await
branch
from
a088710
to
95c7050
Compare
viceice
previously approved these changes
Apr 8, 2020
viceice
reviewed
Apr 8, 2020
viceice
previously approved these changes
Apr 9, 2020
viceice
approved these changes
Apr 9, 2020
|
🎉 This PR is included in version 19.203.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes promises that aren't awaited, except in a few cases:
lib/util/exec/exec/spec.ts&lib/manager/gradle/index.spec.tsas the imports are not so straightforward.This PR also includes a new test util method,
mockPartial, which will calljest.requireActualon a module, then apply the overrides passed to it.