-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(github): Support skipped state for Workflows #5959
Conversation
Doesn't look like there is a way to reword a commit in the GH UI. :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't worry about commit message, we will squash merge anyways.
Needs test case.
skipped
is not documented 🤔
https://developer.github.com/v3/checks/runs/#create-a-check-run
How to do test case? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run yarn prettier-fix
doesn't look like I can, because python is a depedency, and I don't have python installed. I'm on windows.
feel free to commit to this branch though. |
ah, this worked:
|
@viceice requested changes applied ;) |
🎉 This PR is included in version 19.207.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Hopefully Resolves #5956